Skip to content

[PHPStan] Use NodeVisitor::* on RectorInterface::refactor() @return method and update rules to use specific of its constant#7409

Merged
samsonasik merged 2 commits intomainfrom
use-nodevisitor-star
Oct 3, 2025
Merged

[PHPStan] Use NodeVisitor::* on RectorInterface::refactor() @return method and update rules to use specific of its constant#7409
samsonasik merged 2 commits intomainfrom
use-nodevisitor-star

Conversation

@samsonasik
Copy link
Member

@TomasVotruba per your request at #7406 (review)

…ethod and update rules to use specific of its constant
…ethod and update rules to use specific of its constant
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

I will check rector-* packages and update the rules to use the specific constant if there is phpstan notice there.

@samsonasik samsonasik merged commit 5f35406 into main Oct 3, 2025
50 checks passed
@samsonasik samsonasik deleted the use-nodevisitor-star branch October 3, 2025 22:55
@TomasVotruba
Copy link
Member

Awesome, thanks for the fixes 👍

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants